Accept a CCID device instead of a ctaphid device#94
Open
sosthene-nitrokey wants to merge 31 commits intomainfrom
Open
Accept a CCID device instead of a ctaphid device#94sosthene-nitrokey wants to merge 31 commits intomainfrom
sosthene-nitrokey wants to merge 31 commits intomainfrom
Conversation
Collaborator
|
very nice! |
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
2 times, most recently
from
bd2dbda to
5ec9a8c
Compare
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
9 times, most recently
from
fb2c7f8 to
4c27f5d
Compare
|
I saw the new release 2.4.3 today, but this merge was not in. Any ETA when it will be merged? |
Contributor
Author
|
We expect this to be available in January. If you need it before, it's still possible to use a git dependency directly on this branch. |
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
from
4c27f5d to
a2b831a
Compare
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
from
d0a213c to
3a4d82a
Compare
Collaborator
|
otherwise lgtm |
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
4 times, most recently
from
dc9928f to
cf8d464
Compare
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
from
cf8d464 to
a39abcb
Compare
sosthene-nitrokey
force-pushed
the
pcsc-sdk
branch
from
98b0169 to
43b525b
Compare
Member
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
I still need to do some more testing but the code looks good to me. Please add should_default_ccid to docs/api/nitrokey.trussed.rst and add a changelog entry. And I think it would make sense to squash the commits into one before merging.
| f"(expected: {response_len}, actual: {len(response)})" | ||
| ) | ||
| return response | ||
| # return self._call(app.value, app.name, response_len, data) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.